search

igniterealtime / openfire-ofmeet-plugin

Provides an HTTP Online Meeting solution for Openfire using Jitsi Meet.
Apache License 2.0
46 stars 44 forks source link

Force offocus to wait for ofmeet before attempting to connect to videobridge #42

Closed deleolajide closed 6 years ago

deleolajide commented 7 years ago

offocus does a service discovery at startup which sometimes happens before ofmeet is fully loaded and ready. I had to add a Thread.sleep(5000) hack to get consistent results.

guusdk commented 7 years ago

Thanks for taking care of this. I was annoyed by that stacktrace on startup. That service discovery gets redone later, right - I don't think we're actually missing data? As for the wait: I'm pretty sure that there's a event that we can listen for. That will be a more consistent solution than waiting for an arbitrary number of seconds.

On 8 November 2017 at 00:55, Dele Olajide notifications@github.com wrote:

offocus does a service discovery at startup which sometimes happens before ofmeet is fully loaded and ready. I had to add a Thread.sleep(5000) hack to get consistent results.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/igniterealtime/ofmeet-openfire-plugin/issues/42, or mute the thread https://github.com/notifications/unsubscribe-auth/AEDoyhbK5SRiLhV4fm4aVdADfetQ9Ptvks5s0O3kgaJpZM4QVpBO .

deleolajide commented 7 years ago

Not sure if service discovery is tried again, but the list of videobridges remains empty causing offocus to assume there is no available VB. It became more pronounced with my custom version of XMPPTCPConnection with an openfire vitrualconnection.

deleolajide commented 7 years ago

There was a reference to this in the open_chat at igniterealtime.org. Just to point out that I have only applied to my clone. I considered it a hack and not a fix.