igniterealtime / openfire-pade-plugin

A plugin for Openfire that offers web-based unified communications - chat, groupchat, telephone, audio and video conferencing.
Apache License 2.0
57 stars 30 forks source link

Avatar still shows broken in list #168

Closed droobah closed 3 years ago

droobah commented 3 years ago

Since I can't re-open #115 , I had to create a new one. I've attached a screenshot of what I see. What logging do you need for this? I'm not showing any 404 error from either Firefox or Chrome when the page loads and hitting /ofmeet/images/avatar.png pulls up the avatar properly.

screenshot_29

gjaekel commented 3 years ago

Do you use LDAP? If yes, may you please deactivate line 578 by commenting it out using // https://github.com/igniterealtime/openfire-pade-plugin/blob/7078ca06c6f8b1e4d73d96d82e919d758e312284/web/src/main/webapp/custom_ofmeet.js#L576-L579 In you installation, you'll find this file at .../plugins/ofmeet/classes/jtsi-meet/custom_ofmeet.js

@deleolajide If this helps, there seems to be a problem of returned image type from the vCard. Currently, I'm observing the same since the new version of the Jitsi Meet webapp. At the same time, "my" code enhancements concerning the initials used for the vanilla avatar start to get used.

deleolajide commented 3 years ago

@deleolajide If this helps, there seems to be a problem of returned image type from the vCard.

ofmeet uses whatever is stored as a base64 string in the vCard. You can use Pade, Spark or any xmpp client that supports vCards to check the quality of the image or debug the issue.

image

image

This is an Openfire vCard configuration issue and not ofmeet.

gjaekel commented 3 years ago

I added

[...]
  <PHOTO>
    <TYPE>image/jpeg</TYPE> 
    <BINVAL>{jpegPhoto}</BINVAL>
  </PHOTO> 
[..]

to ldap.vcard-mapping to support avatar pictures stored at the WinAD.

I traced it down last minutes: The problem is, that an unset photo result in an empty BINVAL and this is leading to a syntactical wrong line image.

Made pull request #170.