search

igniterealtime / openfire-search-plugin

Adds Jabber Search (XEP-0055) capabilities to Openfire
Apache License 2.0
3 stars 8 forks source link

change to LinkedHashMap to keep order of fields #14

Closed mightymop closed 2 years ago

mightymop commented 3 years ago

(LinkedHashMap, keeps order of inserted Objects) fix #12

https://discourse.igniterealtime.org/t/several-problems-with-search-plugin/89716

guusdk commented 3 years ago

Thanks for this! I'm happy to merge this. Would you mind adding a line to the changelog though?

I'm curious: why is the order of these fields important to you?

mightymop commented 3 years ago

Thanks for this! I'm happy to merge this. Would you mind adding a line to the changelog though?

I'm curious: why is the order of these fields important to you?

i added a line to changelog for Version 1.7.4 but TBC as date...

The order of fields should equal to reported field order because when creating a table view out of the data it is much easier to create new lines without searching for the right index to keep the tables data in sync with the headline

better performance less code

mightymop commented 3 years ago

When will u merge this PR?

guusdk commented 2 years ago

Fell off my radar, apologies. Thanks for the fix!