igniterealtime / pade

Pàdé (Yoruba word for Meet) is a browser extension (Chrome/Edge) based unified communications desktop client for Openfire.
https://igniterealtime.github.io/pade/
Apache License 2.0
104 stars 46 forks source link

Missing offline messages #179

Closed wrooot closed 5 years ago

wrooot commented 5 years ago

If i receive a message while i'm offline and then i run Chrome and Pade automatically starts with it, i see a popup about the new message with buttons View and Ignore. But pressing View opens chat window with that person and new message is not shown. It is also not shown when reopening the window. So Pade catches such offline message, but for some reason discards it without saving to history.

deleolajide commented 5 years ago

Pade uses a background xmpp connection in addition to the Converse xmpp connection. When the Converse window is closed, all messages go to the background connection. This creates the message notification popup, but the message will only be seen when the Converse window is opened via MAM chat history. If the monitoring plugin is not enabled, the message will not show in the chat history as Pade sets Converse to always use MAM.

A work-around might be to set Openfire property route.all-resources to TRUE to make sure both connections receive the offline messages. I have not tested this and unable to confirm.

If that does not work, then I may have to add a preference setting to enable/disable MAM in order for offline messages to be handled on Converse. I need to check code to confirm that as well.

wrooot commented 5 years ago

FYI, this is happening on igniterealtime.org server.

deleolajide commented 5 years ago

I don't think igniterealtime.org server is running monitoring plugin with MAM v2 required by Converse

ClaudeStabile commented 5 years ago

Dele,

I have same issue on Free-Solutions servers. I have the monitoring plugin but with or without pb is being observed. Let me know if i should try out with parameter route.all-resources to TRUE

deleolajide commented 5 years ago

I have the monitoring plugin

What version?

ClaudeStabile commented 5 years ago

Padé version 1.2.7 + monitoring 1.70 set, still the problem offline messages are gone I receive messages via xabber android client, does not loose any offline mess screenshot8 screenshot8

btw my parameter route.all-resources is already set to TRUE by default

deleolajide commented 5 years ago

1.7.0 does not handle MAM properly. Try this one image

Download from https://github.com/igniterealtime/Pade/releases

ClaudeStabile commented 5 years ago

Hi Dele, Just to confirm it fixes the problem at Free-Solutions too. Now ofline messages are in Padé You can close related issues i open for this.

Thanks :)

wrooot commented 5 years ago

If 1.7.1-SNAPSHOT fixes MAM, maybe we should release it?

deleolajide commented 5 years ago

It is more of a hack than a proper fix. It advertises MAM2 for service discovery and relies on Converse to create the missing stanza-id. @guusdk wants to fix the monitoring plugin issues as soon as he can afford the time.