igniterealtime / pade

Pàdé (Yoruba word for Meet) is a browser extension (Chrome/Edge) based unified communications desktop client for Openfire.
https://igniterealtime.github.io/pade/
Apache License 2.0
104 stars 46 forks source link

PWA mode on Android - Link vidconf is incorrectly set /ofmeet is hardcoded in some files #183

Closed ClaudeStabile closed 5 years ago

ClaudeStabile commented 5 years ago

Hello, Vidcall initiated from android in PWA mode does not provide correct ofmeet URL link

Ti reproduce : Initiate a vidcall on android then ofmeetUrl remain incorrect, it still include /ofmeet hardcoded Path. To fix this i did I have found /ofmeet in the following files that include a hardcoded /ofmeet ./jitsi-meet/chrome.ofmeet.js ./jitsi-meet/chrome.config.js ./jitsi-meet/chrome.ofmeet.config.js ./js/background.js ./inverse/index.js ./options/settings.js Then remove default /ofmeet as i use root path for i in grep -rl "ofmeet/" .; do mv $i $i.in && sed 's/ofmeet\///g' $i.in > $i && rm $i.in ; done

But still insufficient as branding.js is not source. To make it work you just neet to go to open the settings /apps/options and it is set properly in both ways PC <--> android so each can initiate vidcalls