if assets.enabled is left blank, the default is now to use the asset pipeline

igor-alexandrov / wisepdf

Wkhtmltopdf wrapper done right

MIT License

281 stars 20 forks source link

if assets.enabled is left blank, the default is now to use the asset pipeline #21

Closed spra85 closed 10 years ago

spra85 commented 10 years ago

The default behavior in Rails now is to use the asset pipeline. The existing conditional in the railtie is !!(::Rails.configuration.assets.enabled). This actually evaluates to false for nil -- which essentially overrides the default behavior to use the legacy helpers.

nil / left blank for assets.enabled should use the asset pipeline. The engine railtie conditional is only run for Rails 3.2 + so we should be able to safely assume asset pipeline is the default.

coveralls commented 10 years ago

Coverage remained the same when pulling 33345d171ee2d86e5d632e31716d2ea339959497 on spra85:rails-asset-pipeline-default into a843b9f6f14e7965d60615d1bfb51c962f053da3 on igor-alexandrov:master.

igor-alexandrov commented 10 years ago

Thanks! Merged in wisepdf-1.3.1.