Fix Issue #156 - Githubissues

igor-makarov / xcake

:cake: Describe Xcode projects in a human readable format and (re)generate one on demand.

MIT License

634 stars 48 forks source link

Fix Issue #156 #173

Closed asifmohd closed 7 years ago

asifmohd commented 7 years ago

Having . or - in folder names would crash xcake

This PR fixes it by checking if the file which needs to be added to a target is a directory or a file. If it's a directory we skip over it.

This fixes #156

coveralls commented 7 years ago

Coverage increased (+0.04%) to 96.939% when pulling 462686057e2bb1977dee86045090a293b56d6933 on asifmohd:master into d04ff8bf6d9e3ba7cee96f00bc49bfab6cb40a6e on jcampbell05:master.

coveralls commented 7 years ago

Coverage increased (+0.05%) to 96.952% when pulling 33423cfe11d89310fe1c6f3e252c00a5326f9b6b on asifmohd:master into d04ff8bf6d9e3ba7cee96f00bc49bfab6cb40a6e on jcampbell05:master.

coveralls commented 7 years ago

Coverage increased (+0.05%) to 96.952% when pulling 33423cfe11d89310fe1c6f3e252c00a5326f9b6b on asifmohd:master into d04ff8bf6d9e3ba7cee96f00bc49bfab6cb40a6e on jcampbell05:master.

coveralls commented 7 years ago

Coverage increased (+0.04%) to 96.939% when pulling 33423cfe11d89310fe1c6f3e252c00a5326f9b6b on asifmohd:master into d04ff8bf6d9e3ba7cee96f00bc49bfab6cb40a6e on jcampbell05:master.

jcampbell05 commented 7 years ago

Thanks, looks great. If you could fix that typo :)

asifmohd commented 7 years ago

@jcampbell05 done :)

coveralls commented 7 years ago

Coverage increased (+0.04%) to 96.939% when pulling 57afcbf05ee61d6d3e9ac0036ebeb433bf38d9eb on asifmohd:master into d04ff8bf6d9e3ba7cee96f00bc49bfab6cb40a6e on jcampbell05:master.

jcampbell05 commented 7 years ago

Thanks @asifmohd