igor-makarov / xcake

:cake: Describe Xcode projects in a human readable format and (re)generate one on demand.
MIT License
634 stars 48 forks source link

Settings.bundle read as folder #185

Closed albyok closed 6 years ago

albyok commented 6 years ago

I noticed now that xcake include file "*.bundle" as folders instead of files. Am I missing something?

image

With a classic project I used to see bundles in this way:

image

And I could attach them to targets.

albyok commented 6 years ago

I'm now using this code to include the Settings.bundle, but it's clearly not the best practice. I also have now two copies of that file. One as folder and one correctly stated as bundle file.

`settingsBundlePath = "target_files/" + target.name + "/Settings.bundle"

target.copy_files_build_phase "Copy Phase - Settings Bundle" do |phase|
    phase.files = [settingsBundlePath] # array
    phase.destination = :resources # can be any of `Constants::COPY_FILES_BUILD_PHASE_DESTINATIONS.keys`
end`
jcampbell05 commented 6 years ago

I think there is a PR that fixes this and I'm about to release it :) since it effects things like xcassets.

albyok commented 6 years ago

Ok, perfect! Thanks for your great work again :-) 🥇

jcampbell05 commented 6 years ago

Should be releasing this today :)

albyok commented 6 years ago

It will be 0.8.11? @jcampbell05

jcampbell05 commented 6 years ago

:) oh forgot I released 0.8.10 already, will be 0.8.11 in that case :)

albyok commented 6 years ago

Ehi James. Is this fix still in progress? I'm sorry to bother you, but for me it would be very important

jcampbell05 commented 6 years ago

Yeah it is :) will get this released today if thats okay ? :) hows you experience otherwise ? anything missing ?

albyok commented 6 years ago

All seemed fine, but I really need this fix. By the way, this script is really saving me, because I have a big project file that I'm sharing through a team and the merge was a pain in the ass.

This script should be integrated in Xcode. Try to contact Apple :D

jcampbell05 commented 6 years ago

Glad to hear it :) Haha, I will try :)