search

igor-tkachev / bltoolkit

Business Logic Toolkit for .NET
MIT License
297 stars 112 forks source link

BLToolkit.Data.DataProvider.SQLite.4, Version=4.3.7.0 is not signed #397

Closed WebSerGe closed 7 years ago

WebSerGe commented 7 years ago

When signed assembly tries to load installed via nuget BLToolkit.Data.DataProvider.SQLite.4, Version=4.3.7.0 then error is raised: Could not load file or assembly 'BLToolkit.Data.DataProvider.SQLite.4, Version=4.3.7.0, Culture=neutral, PublicKeyToken=null' or one of its dependencies. A strongly-named assembly is required. (Exception from HRESULT: 0x80131044) Manual sign of assembly with BLToolkit.snk helps to resolve the issue (disassembling/assembling with key). Can it be fixed?

WebSerGe commented 7 years ago

Pull request is ready, I have never made requests, so I hope it has been done correctly.

WebSerGe commented 7 years ago

Link to pull request https://github.com/igor-tkachev/bltoolkit/pull/398

WebSerGe commented 7 years ago

While issue is opened I use such workaround to bypass run-time errors for sqlite db provider:

  <Target Name="BeforeBuild">
    <Exec ContinueOnError="false" Command="..\..\packages\Brutal.Dev.StrongNameSigner.2.1.0\build\StrongNameSigner.Console.exe -in &quot;..\..\packages\BLToolkit.SQLite.4.3.7\lib\net40|..\..\packages\BLToolkit.4.3.7\lib\net40|..\..\packages\System.Data.SQLite.Core.1.0.105.0\lib\net40&quot; -k BLToolkit.snk" />
  </Target>

Not the best option because it is not generic but will be changed if future releases of database providers will not be strong-named assemblies.

ili commented 7 years ago

Thanks! Now all assemblies are signed, version 4.3.8 published :)