search

igorantolic / ai-esp32-rotary-encoder

Easy implement rotary encoder to your application using microcontroler like ESP32
GNU General Public License v2.0
284 stars 70 forks source link

`encoderVccPin` declared as `uint32_t` so `encoderVccPin >= 0` is always true #57

Closed starlino closed 1 year ago

starlino commented 1 year ago

this cause ESP32 error to be displayed when encoderVccPin == -1

https://github.com/igorantolic/ai-esp32-rotary-encoder/blob/3d2fadd360ff613fe6258735b5eda75da2274a99/src/AiEsp32RotaryEncoder.cpp#L199

maybe make encoderVccPin int32_t, same for the encoderButtonPin

igorantolic commented 1 year ago

Corrected - returned to be int again as designed initially. Should work now again

igorantolic commented 1 year ago

Corrected - returned to be int again as designed initially. Should work now again