igorantolic / ai-esp32-rotary-encoder

Easy implement rotary encoder to your application using microcontroler like ESP32
GNU General Public License v2.0
284 stars 70 forks source link

Added constructor argument to choose pinMode for encoder pins #65

Open fehlfarbe opened 1 year ago

fehlfarbe commented 1 year ago

Hi! My ESP32 based PCB has an encoder that is connected to GND so my pins have to be pulled up. Unfortunately the pinMode is set in the constructor and I cannot change the variable areEncoderPinsPulldownforEsp32 before creating the AiEsp32RotaryEncoder object. That's why I extended the constructor arguments and set the default values so it won't change the current behavior.