search

igorb3st / sipservlets

sipservlets
1 stars 0 forks source link

SIP Outbound (RFC 5626) broken for target refresh #153

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?

1. Have a mobile client initiate e.g. a SIP INVITE to the server. Since it is 
using sip outbound the client will append the "ob" parameter onto the contact 
(and of course will be using TCP).
2. As the mobile swap networks, it will have to update its contact address and 
issues a target refresh request (empty invite) where the new contact address 
states a new ip (which is pretty irrelevant since it will most likely be wrong 
anyway). Of course, this contact header also contains the "ob" parameter.
3. Try and send a BYE to the client

What is the expected output? What do you see instead?

The BYE should make it through.

What version of the product are you using? On what operating system?

mss 1.7.0.Final on Linux

Please provide any additional information below.

I have a patch for it. Will submit it asap.

Original issue reported on code.google.com by jo...@twilio.com on 21 Aug 2012 at 10:49

GoogleCodeExporter commented 8 years ago 
[deleted comment]
GoogleCodeExporter commented 8 years ago 
Patch:

http://code.google.com/r/borjessonjonas-mobicents-sip-servlet/source/detail?r=76
f0ebcf32e0378f48d427dd32c6129ad8a1375c&name=issue-153

Essentially, the fix is just to also "handle sip outbound" in the subsequent 
request dispatcher. The code for handleSipOutbound was therefore moved from 
InitialRequestDispatcher to the base class (RequestDispatcher) so it would be 
accessible for the SubsequentRequestDispatcher.

Original comment by borjesso...@gmail.com on 22 Aug 2012 at 12:17

GoogleCodeExporter commented 8 years ago

Original comment by jean.deruelle on 19 Oct 2012 at 11:17

GoogleCodeExporter commented 8 years ago

Original comment by jean.deruelle on 5 Jul 2013 at 7:44

GoogleCodeExporter commented 8 years ago 
Any chance this will be merged to the mss_2x track soon?

Original comment by jo...@twilio.com on 11 Nov 2013 at 8:11

GoogleCodeExporter commented 8 years ago

Original comment by jean.deruelle on 24 Apr 2014 at 1:58

GoogleCodeExporter commented 8 years ago 
Jonas, can you sign the contributor agreement at 
http://www.telestax.com/opensource/#Contribute and I assume you're still fine 
to be listed as contributor at 
http://www.telestax.com/opensource/acknowledgments/

Original comment by jean.deruelle on 24 Apr 2014 at 2:04

GoogleCodeExporter commented 8 years ago 
Signed...

Original comment by jo...@twilio.com on 24 Apr 2014 at 4:27

GoogleCodeExporter commented 8 years ago 
This issue was updated by revision 23233f8989c0.

 target refresh fix for tcp connection reuse case

(cherry picked from commit 76f0ebcf32e0378f48d427dd32c6129ad8a1375c)

Conflicts:
    sip-servlets-impl/.classpath
    sip-servlets-impl/.project

(cherry picked from commit 832b3b31b5cc3a0564b39fc5cac7a0309f06dd70)

Original comment by jean.deruelle on 25 Apr 2014 at 9:50

GoogleCodeExporter commented 8 years ago

Original comment by jean.deruelle on 25 Apr 2014 at 9:50

GoogleCodeExporter commented 8 years ago 
we don't seem to have received the CLA signed notification. Can you retry ?

Original comment by jean.deruelle on 25 Apr 2014 at 11:08

GoogleCodeExporter commented 8 years ago 
Ok, submitted again..

Original comment by jo...@twilio.com on 25 Apr 2014 at 2:36

GoogleCodeExporter commented 8 years ago

Original comment by jean.der...@telestax.com on 25 Aug 2014 at 10:52