Some corrections and improvements to run with docker compose

igorbenav / FastAPI-boilerplate

An extendable async API using FastAPI, Pydantic V2, SQLAlchemy 2.0, PostgreSQL and Redis.

MIT License

589 stars 69 forks source link

Some corrections and improvements to run with docker compose #62

Closed YuriiMotov closed 10 months ago

YuriiMotov commented 10 months ago

I tried to use this boilerplate and it was unclear to me in some places what to specify in the settings to run it with docker compose. I added more comments in ReadMe and fixed some mistakes.

I also think that it's better to use expose instead of ports in docker compose file for services we don't need to publish for external users (db, redis, web (when it is using behind the nginx)).

igorbenav commented 10 months ago

Hey, @YuriiMotov, great catch! Thank you so much for the fixes.