igorbenav / fastcrud

FastCRUD is a Python package for FastAPI, offering robust async CRUD operations and flexible endpoint creation utilities.
MIT License
693 stars 59 forks source link

Issue with Routes: Extra Slash Appears When Removing Action Names #135

Closed YosstinCode closed 3 months ago

YosstinCode commented 3 months ago

Is your feature request related to a problem? Please describe.

I'm not sure if it's a problem, but what happens is that I want to remove the route names that indicate the action, so this:

image I wanna to pass to something like this:

image but when I try to do it, this happens:

image

Describe the solution you'd like

Since this breaks a bit with what I wanted, and it seems strange to me that when I put an empty string in the endpoint_names argument, an extra slash appears at the end. According to me, one of two things should happen: the first is that it remains as it is by default, or the second, which is what I want, is to remove the extra slash.

image

Describe alternatives you've considered

Regarding solutions, the truth is that it would be to adapt that part. I was considering making a pull request, but it requires first reading the code and, honestly, I'm not sure if I'm at that point yet, but I will try and leave an update soon in any case wheter or not to make a pull request

igorbenav commented 3 months ago

This was fixed in #105. It will be in the next release, probably it will be released by the weekend

igorbenav commented 3 months ago

Fixed in latest release