igorbenav / fastcrud

FastCRUD is a Python package for FastAPI, offering robust async CRUD operations and flexible endpoint creation utilities.
MIT License
644 stars 45 forks source link

Models and Schemas, Batch 3: Task Management #140

Closed slaarti closed 1 month ago

slaarti commented 2 months ago

Description

This is the third batch of models and schemas for #72, making up something like a simple task management system.

Changes

Models, schemas, and doc/docstring updates for:

One thing I want to note is that, in docs/advanced/joins.md, the examples between the "Getting Joined Data Nested" section and the later "One-to-One Relationships" appear to be identical? It feels unnecessarily redundant to me, but I'm not sure what to do about it. I just wanted to get it noted for the review and see if anyone else who reads this has any ideas.

Checklist

igorbenav commented 1 month ago

One thing I want to note is that, in docs/advanced/joins.md, the examples between the "Getting Joined Data Nested" section and the later "One-to-One Relationships" appear to be identical

True, I belive one of those was in another page, probably Advanced CRUD usage, and eventually I changed and didn't notice the repetition.

How would you like to proceed, @slaarti?

slaarti commented 1 month ago

Sorry, right, I meant to say that you might as well go ahead and merge, since this PR didn't really touch that and I forget if one of the later ones to come do either. If none of them do, then I suppose that's something to maybe work on after #72 is closed out.