refactor: :recycle: reuse of select method in FastCRUD

igorbenav / fastcrud

FastCRUD is a Python package for FastAPI, offering robust async CRUD operations and flexible endpoint creation utilities.

MIT License

643 stars 45 forks source link

refactor: :recycle: reuse of select method in FastCRUD #55

Closed dubusster closed 5 months ago

dubusster commented 5 months ago

Description

This PR is a small refactor of #28, it makes use of select method across FastCRUD class to avoid code duplication.

Changes

fast_crud.py : get, get_multi and get_multi_by_cursor

Tests

No tests added, it passes all current ones

Checklist

[x] I have read the CONTRIBUTING document.
[x] My code follows the code style of this project.
[x] All new and existing tests passed.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (31a2066) to head (c940891).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #55 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 64 64 Lines 4166 4156 -10 ========================================= - Hits 4166 4156 -10 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

igorbenav commented 5 months ago

Nice one, thanks!