igorbenav / fastcrud

FastCRUD is a Python package for FastAPI, offering robust async CRUD operations and flexible endpoint creation utilities.
MIT License
530 stars 32 forks source link

Missing model/schema examples #72

Open slaarti opened 1 month ago

slaarti commented 1 month ago

Okay, well, I went through all of the docs/, fastcrud/, and tests/ directories, and compiled all of the tables and schemas that were referenced (sometimes in multiple places, but I just noted where I first saw them) and/or defined. Sometimes there are not-quite-duplicates, like UserCreateSchema and CreateUserSchema, which I noted down separately but should probably be unified somehow.

Item

Order

Customer

Project

Participant

User

Tier

Tier and TierModel are nearly identical, except that TierModel has a field relating it to the ModelTest table; are they supposed to be the same? There's also a TierSchemaTest in the conftest.py files; should TierSchema be renamed to this?

Department

Task

MyModel

Role

Product

Comment

ModelTest

Booking

Customer

OtherModel

Originally posted by @slaarti in https://github.com/igorbenav/fastcrud/issues/68#issuecomment-2093104741

igorbenav commented 3 weeks ago

@slaarti do you still plan to do this?

slaarti commented 3 weeks ago

Oh, I've been not just planning, but actively working on it since the ticket got filed, up until about last week when I kind of got burned out from having gone through multiple iterations of it and then seeing there've been more commits on main and experiencing merge integration hell.

Of course, I'm certainly not about to insist that other work stop or anything, so obviously I need to change up how I'm doing things to not keep running into this. I think my current plan, once I get back on the horse, is to start from a fresh branch off current main and push out multiple smaller PRs than my initial intention had been. Basic overall doc consistency cleanup first, and then adding in the examples in chunks.

igorbenav commented 3 weeks ago

Damn, now I feel bad. Let me know if you need any help.