Closed JakNowy closed 2 weeks ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 100.00%. Comparing base (
03d4a2d
) to head (f8f8713
). Report is 16 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@igorbenav this is ready for review. I'm going to add some docs tomorrow.
I think all that's missing are typing fixes and docs and we're good to go
@igorbenav Added docs and fixed checks. The latest commit makes the code a bit less clean, but it satisfies mypy, it's up to you if you want to keep it. Let me know your thoughts!
Looking really good, @JakNowy, great work!
This implements #79 by introducing
FastCRUD._get_sqlalchemy_filter()
method and a dictonary of filter mappings inFastCRUD._SUPPORTED_FILTERS
. Adding new sqlalchemy opertors is as simple as extending the dictonary.It also solves the
or_()
operator issue:There is some mypy issue which I struggle to solve, but it looks like it's not required. The tests pass with good coverage.