search

igorbenic / wp-sponsors

[WordPress plugin] WP-Sponsors gives your sponsors or partners a separate home where can add a link and a logo. This is the development version of the plugin, for the latest stable release, please check wordpress.org
https://wordpress.org/plugins/wp-sponsors/
GNU General Public License v2.0
6 stars 6 forks source link

add sponsor-class option #11

Closed peppermintpig closed 5 years ago

peppermintpig commented 7 years ago

Allow extra class to be applied to each sponsor container Possible use case: 'col-xs-6 col-md-12 col-lg-6' will fit 1 or 2 sponsors in a theme based on a bootstrap grid.

peppermintpig commented 7 years ago

Hello Jan Me again ;-)

I added an option to add extra classes to each sponsor wrapper. You already have a class for each item + a class for the width However, combined with an option 'size' equals to 'full', if I add a 'sponsor-class' equals to 'col-xs-6 col-md-12 col-lg-6', in a Bootstrap base theme, the sponsors will occupy 100% or 50% of their container, based on the screen size. I hope you get the idea, I can send you an example. I tried to do my best, but feel free to change all stuff I have done to better match your style and habits. As already said, WP and PHP are new to me, as is the fact that the end-user of the plugin have mostly no clue about all those aspects and want a no-brainer stuff that just works... Hope it helps Christophe

janhenckens commented 7 years ago

Hey Christophe

The class options is not an option I want to add to the widget/shortcode in that way. This is however something I get the most questions about in support so I've been thinking about how to fix this a for while. I think I'm going to add a filter so you can add the classes in the functions.php of your theme.

peppermintpig commented 7 years ago

Hello Jan

I ubderstand your concerns

This relates to the complexity of the so many different uses of Wordpress

I was more thinking about a end-user with a limited experience, just able to enter some extra CSS at most

Your aproach is more directed to people that either develop themes or are willing to create a child theme

That is one of the biggest problem of Wordpres: so a diverse audience

That, plus the fact that there is no real templating language. Would love to have a real template decoupled from the logic. But this is and will remain a dream for long...

CU

Christophe

On 5 November 2016 at 07:41, Jan Henckens notifications@github.com wrote:

Hey Christophe

The class options is not an option I want to add to the widget/shortcode in that way. This is however something I get the most questions about in support so I've been thinking about how to fix this a for while. I think I'm going to add a filter so you can add the classes in the functions.php of your theme.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/studioespresso/wp-sponsors/pull/11#issuecomment-258594711, or mute the thread https://github.com/notifications/unsubscribe-auth/AT_9JbJX6jmeMRCaRSaYcCKmDugw8tNTks5q7CT8gaJpZM4Kp9CA .

igorbenic commented 5 years ago

Closed as this plugin was acquired and refactored.