search

igordanchenko / react-photo-album

Responsive photo gallery component for React
https://react-photo-album.com
MIT License
567 stars 35 forks source link

Add react@19 as a peer dependency #187

Closed canastro closed 1 week ago

canastro commented 1 week ago

Is your feature request related to a problem? Please describe.

Next just released a stable version of next@15 which depends on the RC of react@19

Describe the solution you'd like

Is it possible to bump the react / react-dom peer deps to react@19 rc?

Describe alternatives you've considered

No response

Additional context

No response

igordanchenko commented 1 week ago

Can you describe the issue you are facing?

This library uses react peer dependency range >=18, so react@19 is already included in the peer dependency range.

canastro commented 1 week ago

Oh I didn't notice it was >= I automatically read it as ^.

I'm getting this weird error message on pnpm i:

├─┬ react-photo-album 3.0.2
│ └── ✕ unmet peer @types/react@npm:types-react@19.0.0-rc.1: found 19.0.0-rc.1

Anyway, seems to be a problem on my end, so I'll close this PR. Sorry for the confusion.

igordanchenko commented 1 week ago

FWIW the error you quoted above is related to @types/react, not the react RC. You may need to check overrides in your package.json.

canastro commented 1 week ago

Yeah, i did that on the root of the monorepo, but no luck. I've posted a question about this on next's Discord.