search

igordejanovic / parglare

A pure Python LR/GLR parser - http://www.igordejanovic.net/parglare/
MIT License
135 stars 32 forks source link

Failing tests on cyclic grammars with GLR parser #101

Closed SupraSummus closed 4 years ago

SupraSummus commented 4 years ago

test_cyclic_grammar_1 passes if grammar is left unterminated (without EOF). With EOF it seems to be going into infinite loop when parsing.

Same thing may be happening with test_cyclic_grammar_2, but i'm not 100% sure. Maybe it;s something different. I renamed that test to be processed by pytest and have marked it as skipped. (Skipped tests are better than prefixed with todo_ [in my opinion], because they are manifesting themselves when all tests are run - s is printed and at the end you get skipped tests counter.)

I think it's ok to merge this PR right away (without fixing the issue).

coveralls commented 4 years ago

Coverage Status

Coverage increased (+0.2%) to 90.472% when pulling 2df9ded1262690b45ec4ec222b63b0ea0199da71 on SupraSummus:glr_cyclic into de70d377e94832a327473dcbf165c1e91532ea8f on igordejanovic:master.

igordejanovic commented 4 years ago

@SupraSummus Thanks for the contrib. This issue seems to be obsoleted by the EOF removal done on the master branch so I'm closing it. If you think there is still an issue fill free to update/reopen.