Moved some stuff from setup.py into pyproject.toml

igordejanovic / parglare

A pure Python LR/GLR parser - http://www.igordejanovic.net/parglare/

MIT License

136 stars 32 forks source link

Moved some stuff from setup.py into pyproject.toml #119

Open KOLANICH opened 4 years ago

KOLANICH commented 4 years ago

And improved stuff in setup.py a bit

Code review checklist

[ ] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
[x] Title summarizes what is changing
[x] Commit messages are meaningful (see [this][commit messages] for details)
[x] Tests have been included and/or updated
[x] Docstrings have been included and/or updated, as appropriate
[x] Standalone docs have been updated accordingly
[x] Changelog(s) has/have been updated, as needed (see CHANGELOG.md, no need to update for typo fixes and such).

coveralls commented 4 years ago

Coverage increased (+0.01%) to 91.044% when pulling 9e2ff9d9f924f8954b33584a1718f8d2abfd587f on UniGrammar:pyproject.toml into 510318ffea7f4efa161aa6a8881a3f3768062bcd on igordejanovic:master.

igordejanovic commented 4 years ago

@KOLANICH Not sure how is this supposed to work? How do you build a package with this change?

KOLANICH commented 4 years ago

setuptools has one of entry_points used as a hook for other tools, setuptools_scm uses it. Should work out of the box as usual.

igordejanovic commented 4 years ago

Did you tried it? What command do you use to build wheel and source distributions?

KOLANICH commented 4 years ago

Did you tried it?

In fact I haven't tried building parglare for a while (it is installed with -e for me), for other my tools I use the similar setuptools_scm config in pyproject.toml since support of this has been released.

What command do you use to build wheel and source distributions?

As usual python3 ./setup.py bdist_wheel, but python3 -m pep517.build (the new build-backend-independent command) should work too. What does it write for you?

igordejanovic commented 4 years ago

As usual python3 ./setup.py bdist_wheel, but python3 -m pep517.build (the new build-backend-independent command) should work too. What does it write for you?

python setup.py bdist_wheel doesn't pick up version correctly and produces package parglare-0.0.0-py2.py3-none-any.whl. python -m pep517.build does work after pip install pep517. Do you have any reference what is the recommended way to do builds and uploads to PyPI now?

KOLANICH commented 4 years ago

That's extremily strange. I have checked recently, on my machine everything works (I use python3 for building, python2 is EOL). Please make sure that the libs (setuptools and setuptools_scm) are of the latest versions (pyproject.toml should ensure that the versions are compatible though) and that tag is present on the branch.