Added grammar builder - Githubissues

hosford42 commented 3 years ago

Code review checklist

[ ] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
[ ] Title summarizes what is changing
[ ] Commit messages are meaningful (see this for details)
[ ] Tests have been included and/or updated
[ ] Docstrings have been included and/or updated, as appropriate
[ ] Standalone docs have been updated accordingly
[ ] Changelog(s) has/have been updated, as needed (see CHANGELOG.md, no need to update for typo fixes and such).

hosford42 commented 3 years ago

Hi, @igordejanovic! Let me know if this needs anything to get it up to par.

igordejanovic commented 3 years ago

@hosford42 Thanks much for the contribution! I just skimmed through the implementation and it looks very good. I'll do the full review in the next couple of days.

hosford42 commented 3 years ago

Hi @igordejanovic. I'll try to get these changes done later today. Thanks for the feedback, and I'm happy to hear you are pleased.

igordejanovic / parglare

Added grammar builder #128

Code review checklist