[ ] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
[ ] Title summarizes what is changing
[ ] Commit messages are meaningful (see this for details)
[ ] Tests have been included and/or updated
[ ] Docstrings have been included and/or updated, as appropriate
[ ] Standalone docs have been updated accordingly
[ ] Changelog(s) has/have been updated, as needed (see CHANGELOG.md, no need
to update for typo fixes and such).
Hi, @igordejanovic ,
I've made the fix according to our today's discussion.
It may not be guaranteed that the node is always preserved during the whole visitor execution (e.g. if the node is not the AST node, but the tuple containing it). This is the rationale for keeping the reference to the node object in cache.
Code review checklist
CHANGELOG.md
, no need to update for typo fixes and such).Hi, @igordejanovic ,
I've made the fix according to our today's discussion.
It may not be guaranteed that the
node
is always preserved during the wholevisitor
execution (e.g. if thenode
is not the AST node, but the tuple containing it). This is the rationale for keeping the reference to thenode
object incache
.Best, Vladimir