search

igordot / msigdbr

MSigDB gene sets for multiple organisms in a tidy data format
https://igordot.github.io/msigdbr
Other
70 stars 14 forks source link

Added values from the EXACT_SOURCE XML tag to the `sources` column #11

Closed smped closed 4 years ago

smped commented 4 years ago

Hi, These edits seemed to have worked nicely on my machine, and my workflows running Hallmark, C5 & C3 also ran smoothly. Thanks again for setting the package up. Steve

smped commented 4 years ago

Also, this is my attempt at resolving #10

codecov-commenter commented 4 years ago

Codecov Report

Merging #11 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #11   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           23        23           
=========================================
  Hits            23        23
Impacted Files Coverage Δ
R/functions.R 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9ed2768...cae931f. Read the comment docs.

igordot commented 4 years ago

Thank you for the fix. As I was looking over the code, I decided to add some other metadata fields.

smped commented 4 years ago

Glad to help out. I also wanted to express my pleasure at reading your code. Thanks for keeping everything so clean & easy to follow.