Add Valibot contract integration

igorkamyshev / farfetched

The advanced data fetching tool for web applications

https://ff.effector.dev

MIT License

190 stars 34 forks source link

Add Valibot contract integration #430

Closed vitalybaev closed 8 months ago

vitalybaev commented 10 months ago

Valibot is a new popular runtime validation library. This PR adds contracts integration for Farfetched.

vitalybaev commented 10 months ago

Great, no rush and take your time 🙂 I'll take a look at Valibot error messages, maybe we can get something more meaningful from there

igorkamyshev commented 9 months ago

Hey, I've checked all about build of the package and decided to target this PR to branch next-012 with the release 0.12. In the branch, I removed nx and migrated to bare Vite/pnpm.

Do you mind upgrading your PR based on recent changes? If you do not, please let me know, I'll do it myself 🙏

Sorry for such a complicated process of PR merging, there is a time of considerable changes for Farfetched 😇

vitalybaev commented 8 months ago

As discussed I've pushed the changes:

branch synced with the target branch with nx removed
pinned valibot version as 0.28.0 since they improved error messages.
accordingly updated tests to be aligned with the new error messages