search

igorkamyshev / trona

Write DB migrations with SQL and run them with a CLI
MIT License
30 stars 5 forks source link

Evolution custom name (text as optional part) #220

Closed uka17 closed 3 years ago

uka17 commented 3 years ago

Resolve #209

uka17 commented 3 years ago

@igorkamyshev Good idea. Actually, I would add: 1) Exceptions (do not proceed with execution) for cases of any conflict of numbering is found (existing any of 2: 1-abba.sql, 1-baab.sql, 1.sql, 1-.sql) 2) Warning (with promt "Files ... will be ignored because of incorrect name format. Proceed?" in case if there are "not in scope" files (e.g. test.sql, test.txt, *1-incorrect.sql or -1-worng.sql). Let me know what do you think.

igorkamyshev commented 3 years ago

@igorkamyshev Good idea. Actually, I would add:

  1. Exceptions (do not proceed with execution) for cases of any conflict of numbering is found (existing any of 2: 1-abba.sql, 1-baab.sql, 1.sql, 1-.sql)
  2. Warning (with promt "Files ... will be ignored because of incorrect name format. Proceed?" in case if there are "not in scope" files (e.g. test.sql, test.txt, *1-incorrect.sql or -1-worng.sql). Let me know what do you think.

I like these ideas 🧡 let's do it.

uka17 commented 3 years ago

@igorkamyshev Just added what we discussed above. Plus fine tuned a little bit file searching regexp patter.

uka17 commented 3 years ago

Will add. Meanwhile, any plans to check test coverage?

igorkamyshev commented 3 years ago

Will add. Meanwhile, any plans to check test coverage?

Thanks. I don't have any plans about test-coverage now.