igorkasyanchuk / rails_db

Rails Database Viewer and SQL Query Runner
https://www.railsjazz.com/
MIT License
1.46k stars 111 forks source link

Invalid css error when importing foundation (even after updating sass-rails) #11

Closed itsjms closed 8 years ago

itsjms commented 8 years ago

Still having the same: Invalid CSS after "...ules: $modules ": expected "}", was "!global;" occurring when visiting the page.

igorkasyanchuk commented 8 years ago

Works with

gem 'rails_db' gem 'sass', '>= 3.3.14' gem 'sass-rails', '>= 5.0.0' gem 'foundation-rails', '5.5.0.0'

rhuppert commented 8 years ago

I am experiencing the same issue. I'm still on Foundation 4.3.2 and have dependencies preventing updating sass-rails and moving from the zurb-foundation gem to foundation-rails. I wonder if rails_db might would benefit by being an engine and possibly make this a non-issue? Regardless, nice work!

igorkasyanchuk commented 8 years ago

I suggest you to create simple "hello world" app where I (or somebody) can reproduce issue, because it's difficult to understand what env you using and what other gems. Maybe you can create zip-file with source code and put in somewhere, or just repo in github?

Probably I've a solution here, I think it might work. If you (or somebody) can handle this it might be very cool - we can use plain JS/CSS files from Foundation, and just put them into app/assets.

Probably also older version of foundation need to be used.

Another solution can be for you - extract content of rails_db gem to vendor/gems/rails_db', change gemfile, application.js/css, some "requires" and include it in your project as gem 'rails_db', path: 'vendor/gems/rails_db'

PS: looks like zurb-foundation gem is very old now, I really suggest to upgrade, I know it's painful, but better to do it now then later.

igorkasyanchuk commented 8 years ago

Issue is created https://github.com/igorkasyanchuk/rails_db/issues/21 @rhuppert can you handle it? this is instructions how to do development locally https://github.com/igorkasyanchuk/rails_db#local-development I can help if anything, my skype: igorkasyanchuk

rhuppert commented 8 years ago

Thanks for the information. I’m off on holiday as of today, but will give it a shot upon my return to work.

And you are correct, I have been putting off the Foundation update to avoid the pain. Again, thanks for the insight.

From: Igor Kasyanchuk [mailto:notifications@github.com] Sent: Friday, October 30, 2015 1:19 AM To: igorkasyanchuk/rails_db Cc: Ron Huppert Subject: Re: [rails_db] Invalid css error when importing foundation (even after updating sass-rails) (#11)

I suggest you to create simple "hello world" app where I (or somebody) can reproduce issue, because it's difficult to understand what env you using and what other gems. Maybe you can create zip-file with source code and put in somewhere, or just repo in github?

Probably I've a solution here, I think it might work. If you (or somebody) can handle this it might be very cool - we can use plain JS/CSS files from Foundation, and just put them into app/assets.

Probably also older version of foundation need to be used.

Another solution can be for you - extract content of rails_db gem to vendor/gems/rails_db', change gemfile, application.js/css, some "requires" and include it in your project as gem 'rails_db', path: 'vendor/gems/rails_db'

PS: looks like zurb-foundation gem is very old now, I really suggest to upgrade, I know it's painful, but better to do it now then later.

— Reply to this email directly or view it on GitHub https://github.com/igorkasyanchuk/rails_db/issues/11#issuecomment-152457617 . https://github.com/notifications/beacon/ABEcBIurg0jAUYocqS4C_q2ETCVSgBCrks5pAx9ygaJpZM4GV3e6.gif

itsjms commented 8 years ago

Ya making the assets css / js might be the best idea for people to be able to easily integrate this gem. I personally had to give up because we were having to update a bunch of our apps gems and it was causing problems. If we could get around this SASS issues with foundation I think we would be able to use it.

igorkasyanchuk commented 8 years ago

You can already use version of gem from "master", I think it should work. Release planned to be made soon