search

igorkasyanchuk / rails_db

Rails Database Viewer and SQL Query Runner
https://www.railsjazz.com/
MIT License
1.46k stars 111 forks source link

Add simplecov for tests #46

Closed kupolak closed 8 years ago

igorkasyanchuk commented 8 years ago

Please fix specs on Travis CI - https://travis-ci.org/igorkasyanchuk/rails_db/builds/101488279

kupolak commented 8 years ago

Fixed.

kupolak commented 8 years ago

Now, TravisCI build fails.

igorkasyanchuk commented 8 years ago

Maybe try to install on Travis CI this gem (something like)

https://docs.travis-ci.com/user/common-build-problems/#Newer-version-of-CocoaPods-required

So travis CI will install all gems from gemspec + simplecov separatelly and then just require simplecov in rails_spec.rb file

Main idea is to not include this gem as hard dependency to our gem

@bbenezech maybe you can suggest something?

igorkasyanchuk commented 8 years ago

Hi @kubapol, do you plan to try my suggestions?

bbenezech commented 8 years ago

@igorkasyanchuk what is the issue? simple_cov is needed in development for a rake task?

igorkasyanchuk commented 8 years ago

issue is that we just need to edit Travis.yml file in this PR to pass specs in Travis CI but in same time do not add this gem as mandatory dependency

kupolak commented 8 years ago

I'll try to fix it next week. I'm too busy right now.