search

igorkasyanchuk / rails_db

Rails Database Viewer and SQL Query Runner
https://www.railsjazz.com/
MIT License
1.46k stars 111 forks source link

Rails 3.2 Sass method argument error #70

Closed spacewaffle closed 7 years ago

spacewaffle commented 7 years ago

After installing and heading to localhost:3000/rails/db I get a syntax error in a gem scss file

wrong number of arguments (given 1, expected 2) for 'asset-path' (in /Users/Blah/.rvm/gems/ruby-2.3.0/gems/rails_db-1.4.1/app/assets/stylesheets/rails_db/app.scss)

Looking at the gem, asset-path is written like so:

table.custom_sorting th .asc { background-image: asset-path('rails_db/up_arrow.gif'); }

For 3.2 support, we'd need a branch that changes this to table.custom_sorting th .asc { background-image: asset-path('rails_db/up_arrow.gif', 'image'); }

igorkasyanchuk commented 7 years ago

please create a PR and travis will run all tests, if it's ok I'll merge to master. thanks

spacewaffle commented 7 years ago

I took a quick look at the codebase and that .custom_sorting class isn't referenced anywhere else but that css file. Is it possible that's old css that isn't being used anymore? If so, we could just remove those lines.

igorkasyanchuk commented 7 years ago

you know you are absolutely right 👍 it was an old code. you can remove it :) I think you can also remove "arrows" images too

igorkasyanchuk commented 7 years ago

fixed