explicitly use https for fontawesome assets

igorkasyanchuk / rails_db

Rails Database Viewer and SQL Query Runner

https://www.railsjazz.com/

MIT License

1.46k stars 111 forks source link

explicitly use https for fontawesome assets #87

Closed haffla closed 6 years ago

haffla commented 6 years ago

Hello, this might seem like nitpicking but I think it makes sense to always use https for external assets, no matter what. I am actually using CSP and with the current solution I have to whitelist the fontawesome asset twice, the http version for dev and test, plus the https version for production. There is no wildcard for the scheme. Anyway I think it is good practice to force https.

igorkasyanchuk commented 6 years ago

I'm ok with this change, thanks 👍