search

igorkasyanchuk / rails_performance

Monitor performance of you Rails applications (self-hosted and free)
https://www.railsjazz.com/
MIT License
957 stars 54 forks source link

Specify minimal ruby version compatible #10

Closed alagos closed 3 years ago

alagos commented 3 years ago

I just tried the gem in a legacy project using ruby 2.2/rails 4.2, it looks promising, but in rails/performance/requests I got a SyntaxError:

rails_performance-0.9.5/app/views/rails_performance/rails_performance/requests.html.erb:29: syntax error, unexpected ',', expecting :: or '[' or '.'
..._eq: a, format_eq: groups[1]}), remote: true );@output_buffe...
...                               ^:

and that's because of the safe navigation operator &, introduced in ruby 2.3. As I see very unlikely in the short term to upgrade this legacy stack, I'm planning to change those to .try in a fork, see if it works and hopefully don't find any other issue. But anyway, do you have any plans about minimal ruby version to support?