search

igorkasyanchuk / rails_performance

Monitor performance of you Rails applications (self-hosted and free)
https://www.railsjazz.com/
MIT License
957 stars 54 forks source link

Fix navbar toggle #38

Closed d1ceward closed 2 years ago

d1ceward commented 3 years ago

Hello,

This pull request fixes non-working navbar toggle by adding some javascript which toggle is-active css class on the burger and the menu when the burger is clicked.

image

The javascript come from the Bulma documentation (see: https://bulma.io/documentation/components/navbar/#navbarJsExample)

d1ceward commented 2 years ago

Hi, it's been a while, is it good? and could it be merge and release?

igorkasyanchuk commented 2 years ago

Hi, oh :)

yes, all is good, thank you for a reminder

Just forgot about it. Will release later today

d1ceward commented 2 years ago

Awesome, thanks ! :1st_place_medal:

igorkasyanchuk commented 2 years ago

Successfully registered gem: rails_performance (1.0.2)

Try this version and tell me if everything is OK Thanks again

d1ceward commented 2 years ago

Everything is OK, fix works like a charm. image