search

igorkasyanchuk / rails_performance

Monitor performance of you Rails applications (self-hosted and free)
https://www.railsjazz.com/
MIT License
957 stars 54 forks source link

helper methods in this gem collide with own helper methods #9

Closed mastermoo closed 3 years ago

mastermoo commented 3 years ago

The helper methods used in this file override methods in our own app.

For example, when when calling the method icon, instead of our own my implementation, the method from this gem is called.

Does it make sense to just give each helper method in this gem a prefix, so that it won't override any methods of the main app? for e.g. renaming icon to rails_performance_icon.

igorkasyanchuk commented 3 years ago

hi @mastermoo try now new version: rails_performance (0.9.5) and let me know how it works

mastermoo commented 3 years ago

wow, yeah it works perfectly, thanks for taking care of it so quickly!