search

igorlino / elevatezoom-plus

Enhanced elevateZoom - A jQuery image zoom plugin
http://igorlino.github.io/elevatezoom-plus/
MIT License
162 stars 77 forks source link

Need option to specify z-index #52

Open teej043 opened 8 years ago

teej043 commented 8 years ago

It's a nice to have since this plugin doesn't need much custom css, so rather than putting 

.zoomWindowContainer > div{
  z-index: 100!important;
}

to the stylesheet, why not have this option on the initialization itself?

kalebanderson commented 6 years ago

@teej043 there is currently a zIndex option that applies to the inner zoom zoomWindow and the specified container (by default ZoomContainer). The same option applies to the z-index for both classes, which may or may not be working as designed.

I'm not sure which behavior makes sense. If zIndex is set at the container-level, should child divs inherit from that? Or should the container and child divs have separately controlled zIndex values?

In my mind, it makes sense that all child divs would inherit from the parent container. This would be a relatively easy change to make I think.