search

igorlogius / igorlogius

Repository to get into contact and for generic topics and questions which do not fit anywhere else
1 stars 0 forks source link

Link Extras: duplicate menu entries #59

Open siffegh opened 3 hours ago

siffegh commented 3 hours ago

Can you reproduce the issue in a 2nd new unmodified firefox profile with only the addon installed in its latest version on the current stable firefox

yes - Please only select if you actually did!

Steps to Reproduce

Expected Result

Seven options should appear.

Actual Result

There are some extra things above the seven options.

igorlogius commented 2 hours ago

Damn, that looks broken.

There are only supposed to be 3 extra options "open, close and download".

No idea how i missed that, but i'll fix it asap.

Well, fuck me ... when i test it with web-ext (development + debugging tool) it looks correct,

image

Well, that at least explains how i missed this issue during development. So not completely my fault. :sweat_smile:

siffegh commented 2 hours ago

There are only three extras on my working profile, beta, and nightly. The duplication is only on a new install.

What are those options supposed to do, anyway?

igorlogius commented 1 hour ago

The duplication is only on a new install.

yeah, it seems this is something timing related ... Shouldn't be to difficult to fix, but it's kind of annoying to not be able to use the debugging tools for testing and instead having to sideload the extension each time.

What are those options supposed to do, anyway?

Those options should be useful when dealing with mutlple links (in a selection) They allow to execute the mentioned action on alle links at once

These actions divert from the inital intent of this addon but i thought they might be sufficently useful to have at hand, when dealing with links.

For users who mainly use the addon to on single links, this might be a bit annoying to have those options at the top ... and i am still thinking about how to best deal with that.

To mitigate that, i might have to make them configurable (hide, sortable) via the preferences in the next version.

siffegh commented 1 hour ago

To mitigate that, i might have to make them configurable (hide, sortable) via the preferences in the next version.

That's what my next issue would be, as now I really only use it for markdown. Tried the other new options which might be useful though, so either sortable or hideable would work.

igorlogius commented 52 minutes ago

so either sortable or hideable would work.

I'll see what i can do.

PS: the duplication issue should be fixed with 1.4.10