igors48 / timers

DIY LILYGO T-Watch 2020 V3 based project
1 stars 0 forks source link

register all the todos #110

Closed igors48 closed 2 years ago

igors48 commented 2 years ago
file todo issue code ref
rtc.hpp typedef Date (*DateFunc)(); // todo rename to GetDate #111 :heavy_check_mark:
tools.hpp // todo rename to timeTools.hpp and timeTools.cpp #112 :heavy_check_mark:
soundPlayer.cpp 3 todos #113 :heavy_check_mark:
sound.cpp (systemApi->queueSend)(queue, &item, 0xffffffffUL); // todo use const for port max delay #114 :heavy_check_mark:
supervisor.cpp if ((p->systemApi->take)(p->watchMutex, 30)) // todo there was missprint lastEventTimestamp vs lastEventTimestampMutex - tests dont see it #115 :heavy_check_mark:
supervisor.cpp sleepTime = sleepTime - SLEEP_TIME_TRESHOLD; // todo consider the new parameter #116 :heavy_check_mark:
stepperComponent.cpp ButtonComponentState *plusButtonState = (ButtonComponentState *)(state->plusButton->state); // todo fix this long way #117 :heavy_check_mark:
factory.cpp plusButtonState->context = (void *)state; // todo add it to the createButtonStateRef #118 :heavy_check_mark:
factory.cpp char STEPPER_PLUS[] = "+"; // todo find better place #119 :heavy_check_mark:
factory.cpp state->delayTick = 1000; // todo pass as a parameter. depends on portTICK_PERIOD_MS #120 :heavy_check_mark:
component.hpp consider Renderable and EventListener interfaces #121 :heavy_check_mark:
component.hpp void (*onGesture)(Component *component, Gesture gesture); // todo gesture and button events are tile level events. consider remove handlers from component #122 :heavy_check_mark:
component.hpp typedef enum { // todo prefixes to avoid collisions #123 :heavy_check_mark:
buttonComponent.cpp (tftApi->fillRoundRect)(component->x, component->y, component->w, component->h, 4, rectColor); // todo make radius a parameter or const #124 :heavy_check_mark:
clockApp.cpp date = {// todo create const #125 :heavy_check_mark:
clockApp.cpp (manager->switchApp)(gesture == MOVE_UP); // todo should be manager->onGesture let manager decide how to handle #126 :heavy_check_mark:
main.cpp vTaskDelay(1000 / portTICK_PERIOD_MS); // todo supervisor task delay -> const #127 :heavy_check_mark:
main.cpp time_t lastUserEventTimestamp; // todo consider rename. this value is updated by timer wakeup also #128 :heavy_check_mark:
watch.cpp esp_sleep_enable_timer_wakeup(sleepTimeMicros); // todo subtract those delays from sleep time #129 :heavy_check_mark: