search

igorsantos07 / yii-whoops

Integrates the Whoops library into Yii 1.1.
BSD 3-Clause "New" or "Revised" License
8 stars 1 forks source link

Versioning #1

Closed GrahamCampbell closed 10 years ago

GrahamCampbell commented 10 years ago

Package versions should not be specified in composer.json files. They should be specified via git tags.

denis-sokolov commented 10 years ago

Perhaps "should" is a slightly strong word, but it's indeed a much more convenient way that helps avoid complications.

igorsantos07 commented 10 years ago

I completely agree with you. On the other hand, this was made in a couple of hours and I simply followed the Whoops suggestion. Will look at this on the next release :) On 12 May 2014 21:41, "Denis Sokolov" notifications@github.com wrote:

Perhaps "should" is a slightly strong word, but it's indeed a much more convenient way that helps avoid complications.

— Reply to this email directly or view it on GitHubhttps://github.com/igorsantos07/yii-whoops/issues/1#issuecomment-42905713 .

denis-sokolov commented 10 years ago

Could you clarify the "Whoops suggestion"?

igorsantos07 commented 10 years ago

The part that explains how to contribute framework integrations. The sample composer file includes versioning :)

denis-sokolov commented 10 years ago

Oh, thanks. Now I was able to fix it!

igorsantos07 commented 10 years ago

So cool to see cool, happy developers around (: This should be more common nowadays :sigh: