igorsimb / mp-monitor

Django app for scraping Wildberries
1 stars 0 forks source link

fix(views): show the next scrape day and time #116

Closed igorsimb closed 5 months ago

igorsimb commented 5 months ago

Fixes #111

Summary by CodeRabbit

coderabbitai[bot] commented 5 months ago
Walkthrough ## Walkthrough The updates across various files in the project primarily enhance user interface elements and backend functionalities. Changes include improving code readability, updating task scheduling and interval handling in Django with Celery, and refining the display of schedule and interval information in the user interface. These modifications aim to streamline operations and improve user experience in managing periodic tasks and intervals. ## Changes | File Path | Change Summary | |-------------------------------------------------|----------------| | `accounts/templates/account/signup.html` | Reindented conditional blocks for better readability without altering the logic. | | `main/tasks.py` | Added datetime import and logic to update `last_run_at` for `PeriodicTask`. | | `main/templates/main/partials/.../create_interval_form.html` | Changed minimum interval value from 1 to 2. | | `main/templates/main/partials/.../update_interval_form.html` | Updated text to reflect single schedule creation and added next interval info. | | `main/views.py` | Adjusted scrape interval task handling and added next interval run time calculation. | | `mp_monitor/settings.py` | Added a 5-second write lock timeout for SQLite. | | `tests/main/test_main_views.py` | Enhanced tests for user redirection, task presence, and interval calculations. | ## Assessment against linked issues | Objective | Addressed | Explanation | |--------------------------------------------|-----------|-------------| | Show the next scrape day and time (#111) | ✅ | | The changes made in `main/views.py` and `main/templates/main/partials/update_interval_form.html` directly address the objective of showing the next scrape day and time by updating the display of current schedules and adding information about the next parsing interval. This ensures that users are clearly informed about when the next data scrape will occur, aligning with the requirements specified in the linked issue.

Recent Review Details **Configuration used: CodeRabbit UI**
Commits Files that changed from the base of the PR and between a08c9065dffc855d795e019fbf4681bfb6ae13fc and d01c368397459fe2d5512c8249273610fa8628b0.
Files selected for processing (7) * accounts/templates/account/signup.html (1 hunks) * main/tasks.py (3 hunks) * main/templates/main/partials/create_interval_form.html (1 hunks) * main/templates/main/partials/update_interval_form.html (1 hunks) * main/views.py (2 hunks) * mp_monitor/settings.py (1 hunks) * tests/main/test_main_views.py (4 hunks)
Files skipped from review as they are similar to previous changes (7) * accounts/templates/account/signup.html * main/tasks.py * main/templates/main/partials/create_interval_form.html * main/templates/main/partials/update_interval_form.html * main/views.py * mp_monitor/settings.py * tests/main/test_main_views.py
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.