search

igorsimb / mp-monitor

Django app for scraping Wildberries
1 stars 0 forks source link

refactor(factories): change email and username generation in UserFactory #74

Closed igorsimb closed 6 months ago

igorsimb commented 6 months ago

Sequence is preferred over factory.Faker("email") to better match username using similar sequence (e.g. username=user_0, email=user_0@testing.com)

Summary by CodeRabbit

coderabbitai[bot] commented 6 months ago
Walkthrough ## Walkthrough These updates focus on enhancing code clarity and testing reliability within a Django project. The `TenantManager` class has been refined with a docstring for better understanding and a type hint modification for improved compatibility. In testing, the `UserFactory` class sees a shift towards more predictable email and username generation using sequence lambda functions. Additionally, tenant testing accuracy is improved by ensuring querysets are compared as sets, addressing potential issues in assertion logic. ## Changes | File(s) | Change Summary | |-----------------------------------|------------------------------------------------------------------------------------------------------------| | `main/models.py` | Added a docstring to `TenantManager.active` method; included a type hint ignore comment. | | `tests/factories.py` | Updated `UserFactory` for email and username generation using sequence lambda functions. | | `tests/main/.../test_main_models.py` | Modified `test_active_tenant` function to compare active tenants by converting querysets to sets for accurate comparison. |
Tips ### Chat There are 3 ways to chat with CodeRabbit: - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit-tests for this file.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit tests for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository from git and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit tests.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - The JSON schema for the configuration file is available [here](https://coderabbit.ai/integrations/coderabbit-overrides.v2.json). - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json` ### CodeRabbit Discord Community Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback.