search

igorski / MWEngine

Audio engine and DSP library for Android, written in C++ providing low latency performance within a musical context, while providing a Java/Kotlin API. Supports both OpenSL and AAudio.
MIT License
259 stars 45 forks source link

Add Reverb2 Processor #102

Closed robtize closed 4 years ago

robtize commented 4 years ago

I made some changes to the render function in audioengine.cpp because I was getting a lot of crashes. Checking for null pointers seems to have fixed them for the most part. I'm not sure if that's the actual solution but it at least works for now and I haven't been able to reproduce the crashes. Let me know if you think there's a different solution we can merge the reverb and do the crashes separately if you think that's better

robtize commented 4 years ago

Ahh! i see what you mean. I removed the audioengine.cpp changes and found out the crash i was seeing was indeed something on our end thank you!

igorski commented 4 years ago

Looking good and great job in the port! Will take the liberty to camel case the methods for consistency and rename the reverb to schroederMoorerReverb to reflect its difference to the other reverb.