search

igorski / MWEngine

Audio engine and DSP library for Android, written in C++ providing low latency performance within a musical context, while providing a Java/Kotlin API. Supports both OpenSL and AAudio.
MIT License
257 stars 45 forks source link

Noise While adding effects to input channel #162

Closed YogarajRamesh closed 2 years ago

YogarajRamesh commented 2 years ago

Hi @igorski ,

I am trying to add effects(mostly all the effects) to the input channel during live recording. it produce noise in output file. With out effects output files are smooth(with out noise).

I have attached both without and with effects sample files.

 private ReverbSM reverb;
  reverb = new ReverbSM();
_engine.getInputChannel().getProcessingChain().addProcessor(reverb);

song with effect https://mega.nz/file/gUc1UCaa#L81EjrElTzf77cojvz5ytrbF5eTVBgv1_NqirYKJtZA song without effect https://mega.nz/file/tcNVmQBK#YO3G2Dsxr-bnI25Nj730vNz7p-d83tT4fr_fswJrtgo

Thanks in advance @igorski

YogarajRamesh commented 2 years ago

Hi @igorski

We noted that noise not only come during addProcessor(). Also some time during normal recording mic produce that noise.

Thanks in advance @igorski

igorski commented 2 years ago

Sounds like your input signal is hot. A little fail safe clamping has been added in b32043472c086a694f5abdeae2aea4ced3981997 but you might consider adding a Limiter instance to the ProcessingChain of the input channel (as the last effect in the chain).

YogarajRamesh commented 2 years ago

Hi @igorski ,

Thank you for the fail safe clamping. I have tested in more then 4 device(which causes the noise before) now it's clear and better then before. Once again thank you for your time and effort.