search

igoticecream / Snorlax

Xposed module (Android) to check pokemons stats
Other
60 stars 22 forks source link

Nickname limited in number of characters #23

Open krosk opened 8 years ago

krosk commented 8 years ago

The official client can display nicknames with more than 12 characters, but you will not be able to manually write (that is, renaming through client) more than 12 chars.

While there has been no word that the client/server detect tampering of responses through checking the length of nicknames, this is a potential giveaway. You may want to issue a warning to users.

malopetrov commented 8 years ago

As of my understanding app doesn't change the nicknames. They are only displayed customized. No server comunication here.

igoticecream commented 8 years ago

I could add an option to truncate always 12 characters if it exceeds

alucas commented 8 years ago

If they start to check every details like this, their code will grow messy and hard to maintain. Idem for this module.

If they start doing that, It will probably be easier to intercept the anti-tempering function/message.