search

igraph / python-igraph

Python interface for igraph
GNU General Public License v2.0
1.28k stars 247 forks source link

Marking groups using a vertex cover does not work with the matplotlib background #481

Closed vtraag closed 2 years ago

vtraag commented 2 years ago

Describe the bug Highlighting a vertex cover does not work correctly with the matplotlib background.

To reproduce

import igraph as ig
import matplotlib.pyplot as plt
g = ig.Graph.Famous("Zachary")
cliques = g.cliques(4, 4)
fig, ax = plt.subplots()
ig.plot(ig.VertexCover(g, cliques), mark_groups=True, target=ax)

Doing

ig.plot(ig.VertexCover(g, cliques), mark_groups=True)

correctly yields image

This was identified earlier in https://github.com/igraph/usability-benchmarks/pull/1.

Version information igraph 0.9.8 installed from conda-forge channel.

iosonofabio commented 2 years ago

Is this develop or master?

vtraag commented 2 years ago

Released 0.9.8. Should this already be corrected in develop?

iosonofabio commented 2 years ago

Sorry I had missed the last line. develop has a LOT of changes in matplotlib, so I'd suggest we base off that for this kind of improvs and not worry too much about backfilling.

vtraag commented 2 years ago

OK, I'll check whether it's already solved in develop.

vtraag commented 2 years ago

OK, I confirm this is working in develop

image