search

igraph / rigraph

igraph R package
https://r.igraph.org
532 stars 200 forks source link

chore: make libxml optional #1282

Closed Antonov548 closed 4 months ago

Antonov548 commented 4 months ago

Closes https://github.com/igraph/rigraph/issues/1217

aviator-app[bot] commented 4 months ago

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes. Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged using Aviator.

See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.
szhorvat commented 4 months ago

Also, it would be good if someone could test this on a system where libxml2 is not available: make sure it compiles, links, and trying to import a GraphML file gives a nice error. I don't see any reason why it wouldn't work, but just in case ... it's hard for me to hide libxml2 since it comes as standard on macOS.

Antonov548 commented 4 months ago

Also, it would be good if someone could test this on a system where libxml2 is not available: make sure it compiles, links, and trying to import a GraphML file gives a nice error. I don't see any reason why it wouldn't work, but just in case ... it's hard for me to hide libxml2 since it comes as standard on macOS.

I have tried to delete libxml2 on my local virtual env. It compiles and links.

Didn't try to import file, but I will do.