search

igraph / rigraph

igraph R package
https://r.igraph.org
532 stars 200 forks source link

Fix builds with the develop branch of igraph/C #1296

Open krlmlr opened 4 months ago

krlmlr commented 4 months ago

Switch the igraph/C repo to the develop branch, run tools/update-cigraph.sh . This leads to compilation errors that need to be fixed.

Can we make this our priority?

szhorvat commented 4 months ago

It makes sense to do this on a separate branch.

Moving to more auto-generation might make this considerably easier.

Antonov548 commented 3 months ago

It makes sense to do this on a separate branch.

Moving to more auto-generation might make this considerably easier.

Sorry, I maybe out of the context.

Is develop branch in C/igraph is upcoming release? Because I tried to build R/igraph with this branch and there is quite some issues, tests are failing and also I found some problems in the C/igraph in this branch. Should I create pull request to develop branch?

szhorvat commented 3 months ago

Is develop branch in C/igraph is upcoming release?

It will become version 1.0, and has many breaking changes compared to 0.10. However, these breaking changes should be easy to adapt to on the R side, nothing like what happened between 0.9 and 0.10.

I suggest that the rigraph repository should also have a develop branch where compatibility updates are made gradually, in tandem with how the develop branch of the C library evolves.