igraph / rigraph

igraph R package

https://r.igraph.org

532 stars 200 forks source link

sample_forestfire() tests and example :fire: #1318

Closed maelle closed 3 months ago

maelle commented 3 months ago

Fix #1292

test: refactor sample_forestfire() tests to make them smaller and more self-contained
docs: simplify example to not have to deal with log of 0

aviator-app[bot] commented 3 months ago

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes. Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged using Aviator.

See the real-time status of this PR on the Aviator webapp.

Use the Aviator Chrome Extension to see the status of your PR within GitHub.

szhorvat commented 3 months ago

Can we have a 🌳 as well in the title in addition to 🔥? 🤭

maelle commented 3 months ago

@szhorvat it seems we can't :sob: I hope you can review the PR regardless of the title :grin: No hurry though

szhorvat commented 3 months ago

I am on it, just got distracted by something else in the meantime. The 🌳 was just a joke :-)

maelle commented 3 months ago

I know it was a joke but I still wanted to improve the title!! such a disappointment that one cannot add more than one emoji.

szhorvat commented 3 months ago

I think the current example is valuable because it shows the heavy tailed degree distribution, which is mentioned in the docs. Even the warning is valuable as it indicates what's missing from the plot. Is there any way to keep the example? Is it going to interfere with the CI tests?

szhorvat commented 3 months ago

Thanks @maelle for all these improvements! :-) It's great to see how much momentum we gained since you came aboard!