igraph / rigraph

igraph R package

https://r.igraph.org

532 stars 200 forks source link

refactor: simplify code #1333

Closed maelle closed 2 months ago

maelle commented 3 months ago

Now, maybe in R_igraph_mybracket2_names itself there could be a way to have the correct output directly?

aviator-app[bot] commented 3 months ago

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes. Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was closed without merging. If you still want to merge this PR, re-open it.

See the real-time status of this PR on the Aviator webapp.

Use the Aviator Chrome Extension to see the status of your PR within GitHub.

aviator-app[bot] commented 3 months ago

This pull request failed to merge: some CI status(es) failed. Once the issues are resolved, remove the blocked label and re-queue the pull request. Note that the pull request will be automatically re-queued if it has the mergequeue label.

Failed CI(s): Check windows-latest (release)

krlmlr commented 3 months ago

@Antonov548: Should this perhaps be moved to the C code?

Antonov548 commented 3 months ago

@Antonov548: Should this perhaps be moved to the C code?

Yes, maybe it's better to keep such things on C side.

maelle commented 2 months ago

@Antonov548 could you please make a PR, or edit this branch, to put that change to the C code? Thank you!

krlmlr commented 2 months ago

Closing in favor of #1342.