search

igraph / rigraph

igraph R package
https://r.igraph.org
532 stars 200 forks source link

fix: fix reading of LGL and NCOL files (broken in 2.0.0) #1347

Closed szhorvat closed 1 month ago

szhorvat commented 2 months ago

Fixes #1346

I'm sorry, I really don't have time for a test, but I hope someone can add one based on my first comment in #1346.

aviator-app[bot] commented 2 months ago

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes. Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged using Aviator.

See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.
knwng commented 2 months ago

Tried to add unittest for the change in https://github.com/igraph/rigraph/pull/1348. I'm new to R, so please let me know if there's anything not following common practices.

szhorvat commented 2 months ago

@krlmlr @Antonov548 One of the CI issues seems to be that GLPK is not found in the macOS image, so it uses the vendored GLPK.

szhorvat commented 1 month ago

Let me know if there's anything else that you need from me here (it seems to me this is good to go).

krlmlr commented 1 month ago

Thanks!

aviator-app[bot] commented 1 month ago

This pull request failed to merge: PR cannot be automatically rebased, please rebase manually to continue. Once the issues are resolved, remove the blocked label and re-queue the pull request. Note that the pull request will be automatically re-queued if it has the mergequeue label.

Additional debug info: Failed to rebase this PR onto the latest changes from the base branch. You will probably need to rebase this PR manually and resolve conflicts).