search

igraph / rigraph

igraph R package
https://r.igraph.org
532 stars 200 forks source link

Review `rinterface_extra.c` for memory management issues introduced during the 0.10 upgrade #1361

Closed szhorvat closed 1 day ago

szhorvat commented 1 month ago

The 0.10 upgrade introduced some memory management issues. rinterface_extra.c should be searched for these. Details and tips on how to do this effectively are in https://github.com/igraph/rigraph/pull/1356#issuecomment-2098274706

Add any issues found to the following TODO list:

maelle commented 2 weeks ago

@Antonov548 can this be closed?

maelle commented 2 days ago

@Antonov548 friendly reminder :smile_cat:

Antonov548 commented 2 days ago

@Antonov548 friendly reminder 😸

@maelle Sorry, I missed this notification on github. It's a bit hard to manually check rinterface_extra.c but I had quick look of functions and I think we can close this issue and maybe trust our sanitizer in CI.

maelle commented 1 day ago

thank you! no worries!